[13.0][ADD] product_abc_classification #623
Conversation
MiquelRForgeFlow
force-pushed
the
13.0-add-product_ABC_classification
branch
from
899ba4a
to
beb4b78
Compare
MiquelRForgeFlow
force-pushed
the
13.0-add-product_ABC_classification
branch
2 times, most recently
from
33e1c20
to
b3b38a5
Compare
|
And please, could you add some tests? |
MiquelRForgeFlow
force-pushed
the
13.0-add-product_ABC_classification
branch
2 times, most recently
from
c12a750
to
977a934
Compare
|
|
|
Why to use a selection in "Data source" and "Value" if there are just one single option to choose? |
|
|
|
@emagdalenaC2i The screen about level should be unique its intended, You have repeated the number 40. And the selections are also intended, because maybe in the future it's extended. |
MiquelRForgeFlow
force-pushed
the
13.0-add-product_ABC_classification
branch
from
977a934
to
d2cafcb
Compare
So, I can't set an ABC setting of 20%-40%-40% ? |
No, because it doesn't make sense. You can see explained here: https://www.eazystock.com/blog/how-to-use-abc-analysis-for-inventory-management/ |
|
This module is a great idea, but you need to rethink the UI |
|
Ok, but make it sense to use a A-20% B-20% and C-60% settings? |
No. The percentages have to be unique. |
|
I think you could use a method like in the Payment terms |
MiquelRForgeFlow
force-pushed
the
13.0-add-product_ABC_classification
branch
2 times, most recently
from
ce3b927
to
a6690dc
Compare
MiquelRForgeFlow
force-pushed
the
13.0-add-product_ABC_classification
branch
from
a6690dc
to
7bf0c2e
Compare
|
@JordiBForgeFlow done |
|
cc @LoisRForgeFlow @NuriaMForgeFlow @didierdonze |
| class ProductTemplate(models.Model): | ||
| _inherit = "product.template" | ||
|
|
||
| abc_classification_profile_id = fields.Many2one( |
There was a problem hiding this comment.
Hi.
I don't understand why the abc_classification_profile_id is in the variant level, and not in the template level. Does it make sense to set a profile 1 for a variant, and a profile 2 to another variant of the same template ?
Propose to move the profile in the template level. (and just set a related in the variant level).
What do you think ?
Also, it could be great to have an api@depends("categ_id") to set the correct profile automatically when creating a new product, linked to a product_category with a profile defined.
There was a problem hiding this comment.
@legalsylvain Sorry, I didn't have time to check this comment. Well, now if you think the code can be improved, then you can propose a PR for this version or do the refactor in the next one.
There was a problem hiding this comment.
Arf... this require to write migration script to change the model.
I'll see.
But well, it doesn't answer to my question : Does it make sense to set a profile 1 for a variant, and a profile 2 to another variant of the same template ?
Thanks.
There was a problem hiding this comment.
@legalsylvain From my POV it makes more sense in the variant. You can have a variant that is more successful in the market than other, and therefore you classify one as A and other as B.
My 2 cents.
There was a problem hiding this comment.
Not sure you get it.
Of course the level a/b/c should be in the variant.
But the perfil is common for all the variant of a product template, by design.
Concrete counter exemple welcome.
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 8de111d. Thanks a lot for contributing to OCA. ❤️ |
Product ABC Classification
This modules includes the ABC analysis (or ABC classification), which is
used by inventory management teams to help identify the most important
products in their portfolio and ensure they prioritize managing them above
those less valuable.
Managers will create a profile with several levels (percentages) and then the
profiled products will automatically get a corresponding level using the
ABC analysis.